[OSDOCS-15295] Update nw-customize-ingress-error-pages.adoc #96044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/XS
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
xenolinux
added
peer-review-in-progress
xenolinux
added
peer-review-done
|
cc @jldohmann |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
Command correction in Customizing HAProxy error code response pages Here is the documentation link: https://docs.redhat.com/en/documentation/openshift_container_platform/4.16/html/networking/networking-operators#nw-customize-ingress-error-pages_configuring-ingress Here is the current look: Procedure Create a config map named my-custom-error-code-pages in the openshift-config namespace: $ oc -n openshift-config create configmap my-custom-error-code-pages \ --from-file=error-page-503.http \ --from-file=error-page-404.http The above command is not structured properly. We can use the above command as well, and it will execute perfectly. But its structure is not as per our standard procedure. Hence, it needs to be changed. Here is the updatd look: Procedure Create a config map named my-custom-error-code-pages in the openshift-config namespace: $ oc -n openshift-config create configmap my-custom-error-code-pages \ --from-file=error-page-503.http \ --from-file=error-page-404.http [new-commit] Update nw-customize-ingress-error-pages.adoc [new-commit] Update nw-customize-ingress-error-pages.adoc
|
/retest-required |
|
@prithvipatil97: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.redhat.com/en/documentation/openshift_container_platform/4.16/html/networking/networking-operators#nw-customize-ingress-error-pages_configuring-ingress
Here is the current look:
Procedure
Create a config map named my-custom-error-code-pages in the openshift-config namespace:
Here is the updated look:
Procedure
Create a config map named my-custom-error-code-pages in the openshift-config namespace:
Version(s):
RHOCP 4.20, RHOCP 4.19, RHOCP 4.18, RHOCP 4.17, RHOCP 4.16
Issue:
https://issues.redhat.com/browse/OSDOCS-15295
Link to docs preview:
https://96044--ocpdocs-pr.netlify.app/openshift-dedicated/latest/networking/networking_operators/ingress-operator.html
https://96044--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/networking_operators/ingress-operator.html
https://96044--ocpdocs-pr.netlify.app/openshift-rosa/latest/networking/networking_operators/ingress-operator.html
QE review:
Additional information: